Repository navigation
feat: Add parse step to per-file rule - #345
Merged
Merged
Conversation
furtib
force-pushed
the
per-file-parse
branch
4 times, most recently
from
October 9, 2026 06:05
0956aaa to
35d740f
Compare
Move logging into common.py Fix lint issues Update expected action number (since we added an extra parse action) Undo changes to codechecker script
furtib
force-pushed
the
per-file-parse
branch
from
October 16, 2026 08:36
77a285d to
f21ee77
Compare
Szelethus
reviewed
Oct 16, 2026
Szelethus
reviewed
Oct 16, 2026
Szelethus
left a comment
Szelethus
left a comment
Collaborator
There was a problem hiding this comment.
Do I understand correctly that we got rid of the log file? SHould that warrant a major revision? I think so.
Contributor
Author
|
I definitely did not get rid of the log (or anything), its still there. It just makes more sense to expose the result.txt file (thats job is to contain the parse commands result) rather than the log files. I restored it to use the log file. My reasoning for using results.txt is thinking about a fix for: #358 (which should be using results.json) |
Szelethus
approved these changes
Oct 19, 2026
Szelethus
left a comment
Szelethus
left a comment
Collaborator
There was a problem hiding this comment.
Okay, I've tried this out and it works fine, and it seems to not contain any breaking changes. Well done, Tibi! LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
We want complete feature parity between the monolithic and the per-file codechecker rules.
What:
Addresses:
Fixes: #279
Depends on: #311